eh it is not working

common/desktop_environment/i3/default.nix

@@ -18,22 +18,25 @@ with lib;
   options =
     { }
     // lib.attrsets.setAttrByPath cfg_path {
-      enable = lib.mkEnableOption "i3 (X11) desktop environment";
+      enable = lib.mkEnableOption "i3 window manager";
       terminalCommand = mkOption {
         type = lib.types.str;
-        default = "foot";
+        default = "kitty";
         description = "The terminal command to use.";
       };
       extraOptions = mkOption {
         type = lib.types.attrs;
         default = { };
-        description = "Extra options for i3 configuration.";
+        description = "Extra options for i3 home manager configuration.";
       };
     };
 
   config = lib.mkIf cfg.enable {
+    # Enable for all users
     home-manager = {
-      sharedModules = [ ./home_manager ];
+      sharedModules = [
+        ./home_manager
+      ];
     };
 
     services.greetd = {
@@ -47,42 +50,48 @@ with lib;
       };
     };
 
-    # X server
-    services.xserver.enable = true;
-    services.xserver.displayManager = {
-      # kept undefined to allow user selection; greetd is enabled above
+    # Caps Lock as Escape for console/tty
+    console.useXkbConfig = true;
+    services.xserver.xkb = {
+      layout = "us";
+      options = "caps:escape";
     };
 
-    # Environment variables for X11
-    environment.sessionVariables = {
-      XDG_SESSION_TYPE = "x11";
-      XDG_CURRENT_DESKTOP = "i3";
-      XDG_SESSION_DESKTOP = "i3";
+    # flatpaks need this TODO remove flatpaks?
+    xdg.portal = {
+      enable = true;
+      extraPortals = lib.mkForce [
+        pkgs.xdg-desktop-portal-gtk
+      ];
+      config.common.default = [
+        "gtk"
+      ];
     };
 
+    services.xserver = {
+      enable = true;
+
+      # desktopManager = {
+      #   xterm.enable = false;
+      # };
+
+      windowManager.i3 = {
+        enable = true;
+        extraPackages = with pkgs; [
+          # dmenu # application launcher most people use
+          # i3status # gives you the default i3 status bar
+          # i3blocks # if you are planning on using i3blocks over i3status
+        ];
+      };
+    };
+    services.displayManager.defaultSession = "none+i3";
+    # programs.i3lock.enable = true; # default i3 screen locker
+
     environment.systemPackages = with pkgs; [
-      i3
-      i3status
-      i3lock
-      i3-gaps
-      polybar
-      maim
-      xclip
-      xterm
-
-      # Enable backlight/brightness control, audio, etc., similar to sway defaults
-      polybar
-      maim
-      xclip
-      i3
-      i3status
-      i3lock
-      i3-gaps
-      pavucontrol
-      btop
-      nemo
-      feh
-      rofi
+      xorg.xinit
+      xorg.setxkbmap
+      xorg.xset
     ];
+
   };
 }